An i5 2500 is still a burly CPU specially if you over clock it which it easily does, That said the newer i5s are faster out of the box (marginally anyway) and run cooler, but IIRC don't OC as well but are still very good.
IMO its all about how much it costs compared to the newer CPUS you wont notice much of a difference.