YANI: attributes, show godstate

Archived from groups: rec.games.roguelike.nethack (More info?)

Hi All,

just a simple YANI:

when showing final status, indicate not only whether your god was angry
with you, but whether or not you could safely pray. Just to rub it in.

LilWizard died of starvation. attributes: "You could safely pray"


Keith
--
Keith Davies "Trying to sway him from his current kook-
keith.davies@kjdavies.org rant with facts is like trying to create
keith.davies@gmail.com a vacuum in a room by pushing the air
http://www.kjdavies.org/ out with your hands." -- Matt Frisch

Archived from groups: rec.games.roguelike.nethack (More info?)

Dylan O'Donnell <psmithnews@spod-central.org> wrote:
> Keith Davies <keith.davies@kjdavies.org> writes:
>> Hi All,
>>
>> just a simple YANI:
>>
>> when showing final status, indicate not only whether your god was angry
>> with you, but whether or not you could safely pray. Just to rub it in.
>>
>> LilWizard died of starvation. attributes: "You could safely pray"
>
> The relevant source comment:
>
> /*
> * We need to suppress this when the game is over, because death
> * can change the value calculated by can_pray(), potentially
> * resulting in a false claim that you could have prayed safely.
> */
>
> There's code in place that would print the message (actually "You
> could have safely prayed" ), but it's defined out for that reason.

Ah, so it used to be there, but didn't work quite right then.

It wouldn't be right to be told 'you could have prayed' when you
couldn't, so removing it was the right thing, if it couldn't be made to
work correctly.


Keith
--
Keith Davies "Trying to sway him from his current kook-
keith.davies@kjdavies.org rant with facts is like trying to create
keith.davies@gmail.com a vacuum in a room by pushing the air
http://www.kjdavies.org/ out with your hands." -- Matt Frisch

Archived from groups: rec.games.roguelike.nethack (More info?)

Dylan O'Donnell <psmithnews@spod-central.org> wrote:
> Keith Davies <keith.davies@kjdavies.org> writes:
>> Dylan O'Donnell <psmithnews@spod-central.org> wrote:
>
> [prayer ability in final enlightenment]
>
>> > The relevant source comment:
>> >
>> > /*
>> > * We need to suppress this when the game is over, because death
>> > * can change the value calculated by can_pray(), potentially
>> > * resulting in a false claim that you could have prayed safely.
>> > */
>> >
>> > There's code in place that would print the message (actually "You
>> > could have safely prayed" ), but it's defined out for that reason.
>>
>> Ah, so it used to be there, but didn't work quite right then.
>
> No, it's never been live code in a release version. It first appears
> already defined out in 3.2.0, when the message was added to in-game
> enlightenment.

'code is present but not used in this case' is what I was referring to.
Looking at the wording of the comment it seems someone thought of this,
it got put in, and somewhere in dev/test they realized it wouldn't work
correctly and decided to suppress the message before it went live.


Keith
--
Keith Davies "Trying to sway him from his current kook-
keith.davies@kjdavies.org rant with facts is like trying to create
keith.davies@gmail.com a vacuum in a room by pushing the air
http://www.kjdavies.org/ out with your hands." -- Matt Frisch