Generally, no. I would buy an FX machine if I wanted to run lots of VMs, but for most other tasks they're not all that great.
The cores in a recent Intel CPU are something like 70% faster per clock than those in an FX CPU, and most software only heavily uses 1-2 cores, and might lightly use 1-2 more cores. For this reason, even a Core i3 is often considerably faster than an FX-8350 in common tasks like web browsing, gaming, video editing (when GPU accelerated), and office applications - half or more of an FX's cores sit idle. To make matters worse, FX CPUs draw 2-3x the power of an Intel CPU to do the same work, meaning they need big, expensive coolers or will be noisy, need larger power supplies, and motherboards are often more expensive despite being older and (frequently) having fewer features. Even in tasks that can fully utilize all of an FX's cores, an i5 will almost always be faster, and when you factor in power supply, motherboard, and cooler, often cheaper too.
So, today, an FX-8350 is considered a low-end CPU, and if you want to upgrade it, you need to move to an Intel platform. If you go with an i3 instead for around the same price, you have the option of dropping in an i5 or i7 later. Also, the FX's socket, AM3+, will not be receiving any new CPUs. Socket 1151 will be receiving 2 more generations of CPUs, meaning there will be more drop-in upgrades being released for it for several years.